Skip to content

[streams][significant events] fixes loading state and time picker #244970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2025
Merged

[streams][significant events] fixes loading state and time picker #244970

merged 2 commits into from
Dec 3, 2025
+31 −30

Conversation

@klacabane
Copy link
Contributor

@klacabane klacabane commented Dec 2, 2025 •
edited
Loading

Summary

Part of #243831

Fixes the loading state and time picker in the significant events page

@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Feature:SignificantEvents labels Dec 3, 2025
@klacabane klacabane marked this pull request as ready for review December 3, 2025 10:12
@klacabane klacabane requested a review from a team as a code owner December 3, 2025 10:12
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/actionable-obs-team (Team:actionable-obs)

miltonhultgren
miltonhultgren approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally ✅

@klacabane klacabane changed the title [streams][significant events] fixes [streams][significant events] fixes loading state and time picker Dec 3, 2025
@klacabane klacabane enabled auto-merge (squash) December 3, 2025 11:29
@klacabane klacabane merged commit ebe23db into elastic:main Dec 3, 2025
14 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #110 / Controls Dashboard control group hierarchical chaining "before all" hook for "Shows all available options in first Options List control"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 1.1MB 1.1MB +53.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:SignificantEvents release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@klacabane @elasticmachine @miltonhultgren @kibanamachine