Skip to content

[ES|QL] Removes ts-expect-error #245019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2025
Merged

[ES|QL] Removes ts-expect-error #245019

merged 1 commit into from
Dec 3, 2025

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Dec 3, 2025

Summary

Removes the ts-expect-error by fixing the code to adapt to the new ts version

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.3.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 3, 2025
@stratoula stratoula marked this pull request as ready for review December 3, 2025 08:11
@stratoula stratoula requested a review from a team as a code owner December 3, 2025 08:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula enabled auto-merge (squash) December 3, 2025 08:15
@stratoula stratoula merged commit 2b90c9e into elastic:main Dec 3, 2025
27 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
onechat 471.2KB 471.2KB +3.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.1MB 4.1MB +3.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoval bartoval bartoval approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stratoula @elasticmachine @bartoval