Skip to content

Conversation

@AlexGPlay
Copy link
Contributor

@AlexGPlay AlexGPlay commented Dec 3, 2025

Summary

Closes #234829

Right now we have the should show the reset width button only for absolute width columns, and allow resetting to default width test that is asserting 3 different things:

  • When resetting the width of the time column from absolute it goes back to the default
  • When resetting the width of a column that isn't the time column from absolute it goes back to the default
  • A column without absolute width can't be reset

This means that we can split the test into 3 smaller and more focused tests for each of those scenarios. This should help with the timeout as we are no longer waiting for a big one.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@AlexGPlay AlexGPlay self-assigned this Dec 3, 2025
@AlexGPlay AlexGPlay added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Dec 3, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

cc @AlexGPlay

@AlexGPlay AlexGPlay marked this pull request as ready for review December 3, 2025 12:11
@AlexGPlay AlexGPlay requested review from a team as code owners December 3, 2025 12:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@NicholasPeretti NicholasPeretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! Thank you for this ☺️ 🚀

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexGPlay AlexGPlay merged commit f7266e7 into elastic:main Dec 3, 2025
23 checks passed
@jughosta
Copy link
Contributor

jughosta commented Dec 3, 2025

Let's backport to 9.2 as it fails sometimes there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.3.0

Projects

None yet

5 participants