-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Fleet] Add integration knowledge opt out UI setting and enable feature flag #245080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| } | ||
| ]; | ||
|
|
||
| if (selectedItems.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously the Actions button was disabled if there were no integrations selected.
Now the new Manage integration knowledge is available even if there are no selected items.
| await pMap( | ||
| installedPackages.saved_objects, | ||
| async ({ attributes: installation }) => { | ||
| // TODO archiveIterator is different if `install_source !== 'registry'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a different way to create archiveIterator for packages depending on install source, which makes this logic a little complex.
Alternatively we could call reinstallPackageForInstallation which would call all package install steps.
Or skip the reindex if the package is not installed from registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved this for bundled packages and skipping other types (uploaded, custom).
This is similar to who the reinstall logic works: https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/services/epm/packages/reinstall.ts#L29
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
| installation.version, | ||
| { useStreaming: true } | ||
| ); | ||
| await indexKnowledgeBase( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to determine if an installed package already has the latest knowledge base assets created?
If so, we could skip the reindexing for those packages.
@Supplementing You might now this?
We could check the existence of any knowledge_base type assets, but it's not guaranteed it belongs to the latest package version.
{
"id": "apache-README.md",
"type": "knowledge_base"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, theres an internal endpoint that will return the indexed KB docs for the package, along with the current version for each asset.
GET /internal/fleet/epm/packages/{pkgName}/knowledge_base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I could use this to check if knowledge base items exist for the currently installed package version, and if so, skip the reindexing.
[2025-12-03T16:28:40.479+01:00][DEBUG][plugins.fleet] Skipping reindexing knowledge base for package [email protected] - already indexed
| </EuiButtonEmpty> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem grow={false}> | ||
| <EuiButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the setting is changed only when the Save button is clicked.
I'm wondering if it would be simpler to change the setting when the switch is clicked, and get rid of the Save button.
cc @sileschristian
…tion_tests/ci_checks
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
History
|
Summary
Closes https://github.com/elastic/ingest-dev/issues/6276
WIP: add test coverage
installIntegrationsKnowledgeby defaultintegration_knowledge_enabledtoingest_manager_settingsSO to save the UI settingThe
Manage integration knowledgeaction is added to Installed integrations table.Clicking the action opens the flyout about the Knowledge base information and the switch to be able to opt out.

UX design follows Figma
To verify:
Kibana logs
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.