Skip to content

[CI] ES promotion: minor changes #245094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CI] ES promotion: minor changes #245094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8046bdd
remove 7.17 es promotion schedules, builds no longer work, kibana is …
delanni Dec 3, 2025
339429e
exit if promotion was triggered from a non-release-looking branch
delanni Dec 3, 2025
030d73e
Merge branch 'main' into es-promotion-minor-changes
delanni Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .buildkite/pipeline-resource-definitions/kibana-es-snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ spec:
cronline: 0 22 * * * America/New_York
message: Daily build
branch: '8.19'
Daily build (7.17):
Copy link
Member

@jbudz jbudz Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we have 6 more weeks on this, https://www.elastic.co/support/eol.

Do we know if there's a patch that can be made in the interim?

cronline: 0 20 * * * America/New_York
message: Daily build
branch: '7.17'
tags:
- kibana
---
Expand Down Expand Up @@ -91,7 +87,7 @@ spec:
SLACK_NOTIFICATIONS_CHANNEL: '#kibana-operations-alerts'
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true'
allow_rebuilds: true
branch_configuration: main 9.2 9.1 8.19 7.17
branch_configuration: main 9.2 9.1 8.19
default_branch: main
repository: elastic/kibana
pipeline_file: .buildkite/pipelines/es_snapshots/promote.yml
Expand Down Expand Up @@ -140,7 +136,7 @@ spec:
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true'
REPORT_FAILED_TESTS_TO_GITHUB: 'true'
allow_rebuilds: true
branch_configuration: main 9.2 9.1 8.19 7.17
branch_configuration: main 9.2 9.1 8.19
default_branch: main
repository: elastic/kibana
pipeline_file: .buildkite/pipelines/es_snapshots/verify.yml
Expand Down
7 changes: 7 additions & 0 deletions .buildkite/scripts/steps/es_snapshots/trigger_promote.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ set -euo pipefail

export ES_SNAPSHOT_MANIFEST="${ES_SNAPSHOT_MANIFEST:-"$(buildkite-agent meta-data get ES_SNAPSHOT_MANIFEST)"}"

if [[ "${BUILDKITE_BRANCH:-}" =~ ^(main|\d+\.\d+)$ ]] || [[ "${FORCE_PROMOTE:-}" =~ ^(1|true)$ ]]; then
echo "Promoting snapshots on branch: ${BUILDKITE_BRANCH}"
else
echo "ES Promotion is not allowed on feature branch ${BUILDKITE_BRANCH}"
exit 0
fi

cat << EOF | buildkite-agent pipeline upload
steps:
- trigger: 'kibana-elasticsearch-snapshot-promote'
Expand Down
4 changes: 2 additions & 2 deletions src/dev/run_precommit_hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { REPO_ROOT } from '@kbn/repo-info';
import * as Eslint from './eslint';
import * as Stylelint from './stylelint';
import { getFilesForCommit, checkFileCasing } from './precommit_hook';
import { load as yamlLoad } from 'js-yaml';
import { loadAll as yamlLoadAll } from 'js-yaml';
import { readFile } from 'fs/promises';
import { extname } from 'path';

Expand Down Expand Up @@ -119,7 +119,7 @@ class YamlLintCheck extends PrecommitCheck {
for (const file of yamlFiles) {
try {
const content = await readFile(file.getAbsolutePath(), 'utf8');
yamlLoad(content, {
yamlLoadAll(content, {
filename: file.getRelativePath(),
});
} catch (error) {
Expand Down