Skip to content

Allow setting notification indicator position on split button #245151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −4
Open

Allow setting notification indicator position on split button #245151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/platform/packages/private/kbn-split-button/src/split_button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,14 @@ export const WithNotificationIndicator = {
showNotificationIndicator: true,
notifcationIndicatorTooltipContent: 'You have unsaved changes',
notificationIndicatorColor: 'primary',
notificationIndicatorSize: 'l',
size: 'm',
notificationIndicatorSize: 'm',
notificationIndicatorPosition: {
top: 2,
left: 25,
},
size: 's',
color: 'text',
iconType: 'save',
},
render: (args: {
showNotificationIndicator: boolean;
Expand All @@ -205,6 +211,12 @@ export const WithNotificationIndicator = {
notificationIndicatorSize: React.ComponentProps<
typeof SplitButtonWithNotification
>['notificationIndicatorSize'];
notificationIndicatorPosition?: {
top?: number;
right?: number;
};
color: React.ComponentProps<typeof SplitButton>['color'];
iconType: React.ComponentProps<typeof SplitButton>['iconType'];
size: React.ComponentProps<typeof SplitButton>['size'];
}) => (
<SplitButtonWithNotification secondaryButtonIcon="arrowDown" {...args}>
Expand Down
22 changes: 20 additions & 2 deletions src/platform/packages/private/kbn-split-button/src/split_button_with_notification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,22 @@ export type SplitButtonWithNotificationProps = SplitButtonProps & {
notificationIndicatorColor?: IconColor;
notificationIndicatorSize?: IconSize;
notifcationIndicatorTooltipContent?: string;
notificationIndicatorPosition?: {
top?: number;
right?: number;
left?: number;
bottom?: number;
};
notificationIndicatorHasStroke?: boolean;
};

export const SplitButtonWithNotification = ({
showNotificationIndicator = false,
notificationIndicatorColor = 'primary',
notificationIndicatorSize = 'l',
notifcationIndicatorTooltipContent,
notificationIndicatorPosition,
notificationIndicatorHasStroke = true,
...splitButtonProps
}: SplitButtonWithNotificationProps) => {
const euiThemeContext = useEuiTheme();
Expand All @@ -52,9 +61,18 @@ export const SplitButtonWithNotification = ({
data-test-subj="split-button-notification-indicator"
css={{
position: 'absolute' as const,
top: '-10px',
right: secondaryButtonWidth,
top: notificationIndicatorPosition?.top ?? -10,
right: notificationIndicatorPosition?.right ?? secondaryButtonWidth,
left: notificationIndicatorPosition?.left,
bottom: notificationIndicatorPosition?.bottom,
zIndex: 1,
...(notificationIndicatorHasStroke && {
'& svg': {
stroke: 'white',
strokeWidth: '2px',
paintOrder: 'stroke fill',
},
}),
}}
>
<EuiIconTip
Expand Down
Loading