Skip to content

[Lens as Code] Refactor colorByValue schema and transforms #245159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+1,196 −400
Open

[Lens as Code] Refactor colorByValue schema and transforms #245159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4312d7
refactor: colorByValue types
nickofthyme Dec 3, 2025
4615e25
update color transform logic with `to`, `from` steps
nickofthyme Dec 3, 2025
49a4476
chore: cleanup color types and fix type errors
nickofthyme Dec 4, 2025
8222a1d
test: add dynamic color metric example mock
nickofthyme Dec 4, 2025
fcf216b
fix: last step issues and update coloring tests
nickofthyme Dec 4, 2025
c353787
chore: add reverse logic converting state to api
nickofthyme Dec 4, 2025
5659ed9
Merge branch 'main' into fix-color-transforms
nickofthyme Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/platform/packages/shared/kbn-coloring/src/palettes/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,18 @@ export interface CustomPaletteParams {
reverse?: boolean;
rangeType?: 'number' | 'percent';
continuity?: PaletteContinuity;
/**
* @deprecated - appears to be unused
*/
progression?: 'fixed';
rangeMin?: number;
rangeMax?: number;
/** lower color stops */
rangeMin?: number | null;
rangeMax?: number | null;
/** upper bounds of color stops ranges */
stops?: ColorStop[];
/** upper color stops */
/** lower bounds of color stops ranges */
colorStops?: ColorStop[];
steps?: number;
maxSteps?: number | undefined;
maxSteps?: number;
}

export type RequiredPaletteParamTypes = Assign<
Expand All @@ -159,5 +162,5 @@ export type RequiredPaletteParamTypes = Assign<

export interface ColorStop {
color: string;
stop: number;
stop: number | null;
}
4 changes: 2 additions & 2 deletions ...m/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/legacy_metric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { schema } from '@kbn/config-schema';
import { esqlColumnSchema, genericOperationOptionsSchema } from '../metric_ops';
import { datasetSchema, datasetEsqlTableSchema } from '../dataset';
import { layerSettingsSchema, sharedPanelInfoSchema, dslOnlyPanelInfoSchema } from '../shared';
import { applyColorToSchema, colorByValueAbsolute } from '../color';
import { applyColorToSchema, colorByValueAbsoluteSchema } from '../color';
import { horizontalAlignmentSchema, verticalAlignmentSchema } from '../alignments';
import { mergeAllMetricsWithChartDimensionSchema } from './shared';

Expand Down Expand Up @@ -73,7 +73,7 @@ const legacyMetricStateMetricOptionsSchema = schema.object({
/**
* Color configuration
*/
color: schema.maybe(colorByValueAbsolute),
color: schema.maybe(colorByValueAbsoluteSchema),
});

export const legacyMetricStateSchemaNoESQL = schema.object({
Expand Down
6 changes: 3 additions & 3 deletions ...platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/metric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
esqlColumnSchema,
genericOperationOptionsSchema,
} from '../metric_ops';
import { colorByValueAbsolute, staticColorSchema, applyColorToSchema } from '../color';
import { colorByValueAbsoluteSchema, staticColorSchema, applyColorToSchema } from '../color';
import { datasetSchema, datasetEsqlTableSchema } from '../dataset';
import {
collapseBySchema,
Expand Down Expand Up @@ -116,7 +116,7 @@ const metricStatePrimaryMetricOptionsSchema = schema.object({
/**
* Color configuration
*/
color: schema.maybe(schema.oneOf([colorByValueAbsolute, staticColorSchema])),
color: schema.maybe(schema.oneOf([colorByValueAbsoluteSchema, staticColorSchema])),
/**
* Where to apply the color (background or value)
*/
Expand Down Expand Up @@ -155,7 +155,7 @@ const metricStateSecondaryMetricOptionsSchema = schema.object({
/**
* Color configuration
*/
color: schema.maybe(schema.oneOf([colorByValueAbsolute, staticColorSchema])),
color: schema.maybe(schema.oneOf([colorByValueAbsoluteSchema, staticColorSchema])),
});

const metricStateBreakdownByOptionsSchema = schema.object({
Expand Down
Loading