[Fleet] Agent actions menu redesign #245174
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🚧 WIP 🚧
TODO:
Closes #238091
This PR cleans up the agent actions menus in the agent table row, the bulk actions, and the agent details page.
Each actions menu was just different enough that unifiying them into one reusable component was not feasible. We would have lots of conditional rendering work based on where the component was being used, etc. Each one has different items, callbacks, etc.
With this in mind, and also taking notice that EUI already handles menu-nesting, I instead decided to create a reusable actions menu component that wraps up the popover, trigger (button), and context menu. It renders the button (with the styling configurable via props), allows you to set popover direction, and automatically handles nesting of children items in the menus. So from a DX perspective, we will still create
MenuItemsarrays in each of the three places, but we wont need to worry with building the UI in the array, just pass in an object like:Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.