-
Notifications
You must be signed in to change notification settings - Fork 3.5k
remove Bundler::DepProxy tweaks #14919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
since ruby/rubygems#5698 Bundler no longer has a DepProxy class, so we can remove the tweaks for it.
end | ||
end | ||
end | ||
DepProxy.class_eval do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this sounds it consumes alot memory now. Do we need to find alternative solution or need to scale up the machine we are running on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
end | ||
end | ||
end | ||
DepProxy.class_eval do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Actually let's hold off on merging this. After double checking, Bundler 2.4 is accumulating object somewhere too and |
@andsel can you look into this? |
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
|
This was solved in fe1b1ed |
since ruby/rubygems#5698 Bundler no longer has a DepProxy class, so we can remove the tweaks for it.
This fixes Logstash crash since bump to Bundler 2.4:
To test, run
./gradlew generatePluginsVersion