Skip to content

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Feb 27, 2023

since ruby/rubygems#5698 Bundler no longer has a DepProxy class, so we can remove the tweaks for it.

This fixes Logstash crash since bump to Bundler 2.4:

> Task :generatePluginsVersion FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/Users/joaoduarte/elastic/logstash/rubyUtils.gradle' line: 143

* What went wrong:
Execution failed for task ':generatePluginsVersion'.
> (null) uninitialized constant Bundler::DepProxy


To test, run ./gradlew generatePluginsVersion

since ruby/rubygems#5698 Bundler no longer
has a DepProxy class, so we can remove the tweaks for it.
@jsvd jsvd marked this pull request as ready for review February 28, 2023 09:48
end
end
end
DepProxy.class_eval do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this sounds it consumes alot memory now. Do we need to find alternative solution or need to scale up the machine we are running on?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mashhurs I think it is ok. As per @jsvd description on the PR:

since https://github.com/rubygems/rubygems/pull/5698 Bundler no longer has a DepProxy class, so we can remove the tweaks for it.

Then it sounds like this no longer exists, and not needed.

Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

end
end
end
DepProxy.class_eval do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mashhurs I think it is ok. As per @jsvd description on the PR:

since https://github.com/rubygems/rubygems/pull/5698 Bundler no longer has a DepProxy class, so we can remove the tweaks for it.

Then it sounds like this no longer exists, and not needed.

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsvd
Copy link
Member Author

jsvd commented Mar 2, 2023

Actually let's hold off on merging this. After double checking, Bundler 2.4 is accumulating object somewhere too and generatePluginsVersion won't complete on just 4gb of heap.

@roaksoax
Copy link
Contributor

roaksoax commented Mar 2, 2023

@andsel can you look into this?

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
@jsvd jsvd marked this pull request as draft August 8, 2025 14:24
@jsvd
Copy link
Member Author

jsvd commented Aug 8, 2025

This was solved in fe1b1ed

@jsvd jsvd closed this Aug 8, 2025
@jsvd jsvd deleted the fix_plugin_docs_rake_w_bundler_2_4 branch August 8, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify status:approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants