Skip to content

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Feb 21, 2025

update metricbeat .monitoring-logstash-8-mb to .monitoring-logstash-9-mb

wait until [1], [2] get merged

@kaisecheng kaisecheng requested a review from mashhurs February 21, 2025 17:05
@kaisecheng kaisecheng changed the title update serverless test indice update serverless test index Feb 21, 2025
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kaisecheng kaisecheng changed the title update serverless test index [CI] update serverless test index Feb 21, 2025
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM!

Some questions:

  • One thing if we can validate: when upstream KB & ES changes get merged, serverless integration tests expectedly should fail, right? It would be great if we can validate first.
  • Does serverless tests run on main only? I mean how are we covering 8.x?

@kaisecheng
Copy link
Contributor Author

serverless integration tests expectedly should fail, right?

Yes. good suggestion

Does serverless tests run on main only? I mean how are we covering 8.x?

Yes, main only. You are right. We should cover 8x. Let me create an issue to track it.

@kaisecheng
Copy link
Contributor Author

follow-up for testing 8.x #17154

@consulthys
Copy link

@kaisecheng the PRs above have been merged

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
@kaisecheng kaisecheng merged commit bdca644 into elastic:main Apr 30, 2025
5 of 6 checks passed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants