Skip to content

[test] ls2ls spec adds heartbeat to keep alive #17228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Mar 5, 2025

From: Mashhurs yaauie#5

Adds heartbeat-input to the LS to LS integration test config to keep upstream Logstash alive.

Copy link
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a comment on the input why it's needed

@@ -22,6 +22,15 @@ config:
generator {
count => '<%=options[:generator_count]%>'
}
heartbeat {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that specify the reason why it's needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces this with reload: #17246

@kaisecheng kaisecheng merged commit 34416fd into elastic:main Mar 5, 2025
5 of 6 checks passed
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ

(cherry picked from commit 34416fd)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 5, 2025

@mashhurs mashhurs added backport-9.0 Automated backport to the 9.0 branch with mergify backport-8.18 Automated backport with mergify labels Mar 5, 2025
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ

(cherry picked from commit 34416fd)
mergify bot pushed a commit that referenced this pull request Mar 5, 2025
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ

(cherry picked from commit 34416fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport with mergify backport-9.0 Automated backport to the 9.0 branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants