-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[test] ls2ls spec adds heartbeat to keep alive #17228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add a comment on the input why it's needed
@@ -22,6 +22,15 @@ config: | |||
generator { | |||
count => '<%=options[:generator_count]%>' | |||
} | |||
heartbeat { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment that specify the reason why it's needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR replaces this with reload: #17246
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
|
💔 Build Failed
Failed CI Steps
History
|
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
Adds heartbeat-input to the LS to LS integration test config to flush the last batch from PQ (cherry picked from commit 34416fd)
From: Mashhurs yaauie#5
Adds heartbeat-input to the LS to LS integration test config to keep upstream Logstash alive.