Skip to content

Update docset.yml to distinguish between major version and major.minor #17562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Update docset.yml to distinguish between major version and major.minor #17562

merged 3 commits into from
Apr 17, 2025

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Apr 15, 2025 •
edited
Loading

fixes major-version to be "9.x", which is only used for the package installation section:

❯ grep major-version docs/ -r
docs//docset.yml:  major-version: "9.0"
docs//reference/installing-logstash.md:Save the repository definition to  /etc/apt/sources.list.d/elastic-{{major-version}}.list:
docs//reference/installing-logstash.md:echo "deb [signed-by=/usr/share/keyrings/elastic-keyring.gpg] https://artifacts.elastic.co/packages/{{major-version}}/apt stable main" | sudo tee -a /etc/apt/sources.list.d/elastic-{{major-version}}.list
docs//reference/installing-logstash.md:[logstash-{{major-version}}]
docs//reference/installing-logstash.md:name=Elastic repository for {{major-version}} packages
docs//reference/installing-logstash.md:baseurl=https://artifacts.elastic.co/packages/{{major-version}}/yum

closes #17561

@jsvd
Update docset.yml to distinguish between major version and major.minor
8bdcf74 
it is the start of a fix to #17561

but requires documentation refactoring after these attributes are changed.
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

@github-actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17562.docs-preview.app.elstc.co/diff

mashhurs
mashhurs reviewed Apr 15, 2025
View reviewed changes
@mashhurs mashhurs added the backport-9.0 Automated backport to the 9.0 branch with mergify label Apr 15, 2025
jsvd
jsvd commented Apr 17, 2025
View reviewed changes
jsvd
jsvd commented Apr 17, 2025
View reviewed changes
@jsvd jsvd marked this pull request as ready for review April 17, 2025 07:26
@github-actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17562.docs-preview.app.elstc.co/diff

1 similar comment
@github-actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17562.docs-preview.app.elstc.co/diff

@jsvd jsvd requested review from mashhurs and robbavey April 17, 2025 08:04
mashhurs
mashhurs approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

karenzone
karenzone approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this fix!

@jsvd jsvd merged commit 005358f into main Apr 17, 2025
8 checks passed
@jsvd jsvd deleted the jsvd-patch-4 branch April 17, 2025 16:13
mergify bot pushed a commit that referenced this pull request Apr 17, 2025
@jsvd @mergify
set major-version to "9.x" used only for the package installation sec…
349179f 
…tion (#17562)

closes #17561

(cherry picked from commit 005358f)
@mergify mergify bot mentioned this pull request Apr 17, 2025
Merged
jsvd added a commit that referenced this pull request Apr 17, 2025
@mergify @jsvd
set major-version to "9.x" used only for the package installation sec…
1b06d13 
…tion (#17562) (#17571)

closes #17561

(cherry picked from commit 005358f)

Co-authored-by: João Duarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenzone karenzone karenzone approved these changes

@mashhurs mashhurs mashhurs approved these changes

@robbavey robbavey Awaiting requested review from robbavey

Assignees

No one assigned

Labels

backport-9.0 Automated backport to the 9.0 branch with mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is typo in the rpm repo documentation for 9.0

4 participants

@jsvd @robbavey @karenzone @mashhurs