Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.
  • Can you please add the appropriate labels needed for backporting?

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

This pull request does not have a backport label. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

@github-actions
Copy link
Contributor

📃 DOCS PREVIEWhttps://logstash_bk_17566.docs-preview.app.elstc.co/diff

@karenzone karenzone added the backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches label Apr 16, 2025
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit 47d430d into elastic:main Apr 16, 2025
9 checks passed
@github-actions
Copy link
Contributor

@Mergifyio backport 9.0

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2025

backport 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 16, 2025
karenzone pushed a commit that referenced this pull request Apr 16, 2025
(cherry picked from commit 47d430d)
Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches docs Team:Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants