Skip to content

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Apr 22, 2025

benchmark script failed to start in v8 due to unrecognised v9 setting xpack.monitoring.allow_legacy_collection
This commit removed the setting when the running version is less than 9

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2025

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@kaisecheng kaisecheng marked this pull request as ready for review April 22, 2025 22:56
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kaisecheng
Copy link
Contributor Author

Cancelled the CI
It has passed the previous failure

@kaisecheng kaisecheng requested a review from mashhurs April 22, 2025 23:05
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you!

@mashhurs mashhurs merged commit 14a35a4 into elastic:main Apr 22, 2025
9 of 10 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants