[chore] support markdown and asciidoc release notes #17621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit preserves asciidoc release note generator to `generate_release_notes.rb` for v7 backward compatibility. Markdown generator moves to `generate_release_notes_md.rb`. The workflow default value is updated. Fixes: #16853
|
This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
|
kaisecheng
added
the
backport-active-9
kaisecheng
commented
May 1, 2025
|
💚 Build Succeeded
History
|
|
@Mergifyio backport 9.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2025
This commit preserves asciidoc release note generator to `generate_release_notes.rb` for v7 backward compatibility. Markdown generator moves to `generate_release_notes_md.rb`. The workflow default value is updated. Fixes: #16853 Follow-up of #17613 (cherry picked from commit 814c6cd) # Conflicts: # .github/workflows/gen_release_notes.yml # tools/release/generate_release_notes.rb # tools/release/generate_release_notes_md.rb
kaisecheng
added a commit
that referenced
this pull request
May 1, 2025
… notes (#17622) This commit preserves asciidoc release note generator to `generate_release_notes.rb` for v7 backward compatibility. Markdown generator moves to `generate_release_notes_md.rb`. The workflow default value is updated. Fixes: #16853 Follow-up of #17613 (cherry picked from commit 814c6cd) --------- Co-authored-by: kaisecheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit preserves asciidoc release note generator to
generate_release_notes.rbfor v7 backward compatibility.Markdown generator moves to
generate_release_notes_md.rb.Prior to this change, in case v7 needs a release, the workflow runs
generate_release_notes_asciidoc.rbinmainand the script checkouts7.17branch. However, v7 does not have the newgenerate_release_notes_asciidoc.rb. So, it is better to keep the asciidoc generation togenerate_release_notes.rbFollow-up of #17613
Fixes: #16853