Skip to content

Conversation

vishaangelova
Copy link
Contributor

@vishaangelova vishaangelova commented May 26, 2025

Release notes

[rn:skip]

What does this PR do?

This PR clarifies the API key format required for Logstash in the following docs:

  • docs/reference/secure-connection.md
  • docs/reference/connecting-to-cloud.md
  • docs/reference/using-logstash-with-elastic-integrations.md

Related issues

Closes #17687

Changes

(All links are to the PR preview)

Previews

https://docs-v3-preview.elastic.dev/elastic/logstash/pull/17688/reference
https://docs-v3-preview.elastic.dev/elastic/logstash/pull/17688/reference/secure-connection
https://docs-v3-preview.elastic.dev/elastic/logstash/pull/17688/reference/connecting-to-cloud
https://docs-v3-preview.elastic.dev/elastic/logstash/pull/17688/reference/using-logstash-with-elastic-integrations (UPDATE: After the review round, I’ve decided to keep this file unchanged.)

@vishaangelova vishaangelova added enhancement docs backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels May 26, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@vishaangelova vishaangelova self-assigned this May 26, 2025
@vishaangelova vishaangelova requested a review from ppf2 May 26, 2025 21:53
@vishaangelova vishaangelova marked this pull request as draft May 27, 2025 11:01
@vishaangelova vishaangelova marked this pull request as ready for review May 28, 2025 08:51
@vishaangelova vishaangelova force-pushed the serverless-clarify-api-key-when-using-logstash branch 2 times, most recently from aea8d98 to c6d674e Compare June 4, 2025 09:05
@karenzone
Copy link
Contributor

Looking...

@vishaangelova vishaangelova removed their assignment Jun 17, 2025
@vishaangelova vishaangelova force-pushed the serverless-clarify-api-key-when-using-logstash branch from ef40eff to 96e4b47 Compare June 24, 2025 07:32
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions (and questions) inline. Thanks for your work on this.

@vishaangelova vishaangelova force-pushed the serverless-clarify-api-key-when-using-logstash branch 4 times, most recently from e83902e to 8352025 Compare June 26, 2025 08:24
@vishaangelova vishaangelova force-pushed the serverless-clarify-api-key-when-using-logstash branch from 8352025 to 19a3461 Compare June 26, 2025 08:27
@karenzone karenzone self-requested a review June 26, 2025 17:53
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the good work on this, @vishaangelova.

@vishaangelova vishaangelova merged commit b238824 into main Jun 27, 2025
8 checks passed
@vishaangelova vishaangelova deleted the serverless-clarify-api-key-when-using-logstash branch June 27, 2025 15:07
@github-actions
Copy link
Contributor

@Mergifyio backport 9.0 9.1

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 27, 2025
* Add clarification about API key format for Logstash

(cherry picked from commit b238824)
mergify bot pushed a commit that referenced this pull request Jun 27, 2025
* Add clarification about API key format for Logstash

(cherry picked from commit b238824)
vishaangelova added a commit that referenced this pull request Jun 27, 2025
…7748)

* Add clarification about API key format for Logstash

(cherry picked from commit b238824)

Co-authored-by: Visha Angelova <[email protected]>
vishaangelova added a commit that referenced this pull request Jun 27, 2025
…7749)

* Add clarification about API key format for Logstash

(cherry picked from commit b238824)

Co-authored-by: Visha Angelova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Serverless]: Clarify API key when using Logstash

4 participants