Skip to content

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Jun 30, 2025

Release notes

Dropped the persistent queue setting queue.checkpoint.interval.

What does this PR do?

queue.checkpoint.interval has never been implemented.
This commit adds warning message when it is used and cleans up references.

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • start Logstash with and without queue.checkpoint.interval

How to test this PR locally

When the config is set in logstash.yml or pipelien.yml, a warning message is logged.

Related issues

Use cases

Screenshots

Logs

`queue.checkpoint.interval` has never been implemented.
This commit adds warning message when it is used and cleans up references.
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2025

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@kaisecheng kaisecheng changed the title Remove queue.checkpoint.interval from user config Remove PQ setting queue.checkpoint.interval Jun 30, 2025
@kaisecheng kaisecheng changed the title Remove PQ setting queue.checkpoint.interval [WIP] Remove PQ setting queue.checkpoint.interval Jun 30, 2025
@kaisecheng kaisecheng changed the title [WIP] Remove PQ setting queue.checkpoint.interval Remove PQ setting queue.checkpoint.interval Jul 3, 2025
@kaisecheng kaisecheng linked an issue Jul 8, 2025 that may be closed by this pull request
@kaisecheng kaisecheng changed the title Remove PQ setting queue.checkpoint.interval Obsolete PQ setting queue.checkpoint.interval Jul 14, 2025
@github-actions
Copy link
Contributor

🔍 Preview links for changed docs

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

❯ tail -n1 logs/logstash-deprecation.log
[2025-07-15T09:03:55,103][WARN ][deprecation.logstash.runner] The setting `queue.checkpoint.interval` has no effect and will be removed from both logstash.yml and pipeline.yml in a future release.

@kaisecheng kaisecheng merged commit 521af3b into main Jul 15, 2025
12 checks passed
@kaisecheng kaisecheng deleted the remove_q_checkpoint_interval branch July 15, 2025 10:40
@kaisecheng kaisecheng added the backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches label Jul 15, 2025
@kaisecheng
Copy link
Contributor Author

@Mergifyio backport 9.0 9.1

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 15, 2025
`queue.checkpoint.interval` has never been implemented.
This commit adds warning message when it is used and cleans up references.

(cherry picked from commit 521af3b)

# Conflicts:
#	logstash-core/lib/logstash/environment.rb
#	logstash-core/spec/logstash/queue_factory_spec.rb
mergify bot pushed a commit that referenced this pull request Jul 15, 2025
`queue.checkpoint.interval` has never been implemented.
This commit adds warning message when it is used and cleans up references.

(cherry picked from commit 521af3b)
kaisecheng added a commit that referenced this pull request Jul 16, 2025
`queue.checkpoint.interval` has never been implemented.
This commit adds warning message when it is used and cleans up references.

(cherry picked from commit 521af3b)

Co-authored-by: kaisecheng <[email protected]>
kaisecheng added a commit that referenced this pull request Jul 22, 2025
…#17824)

* Obsolete PQ setting queue.checkpoint.interval  (#17759)

`queue.checkpoint.interval` has never been implemented.
This commit adds warning message when it is used and cleans up references.

(cherry picked from commit 521af3b)

# Conflicts:
#	logstash-core/lib/logstash/environment.rb
#	logstash-core/spec/logstash/queue_factory_spec.rb

* merge conflict

---------

Co-authored-by: kaisecheng <[email protected]>
Co-authored-by: Kaise Cheng <[email protected]>
colleenmcginnis added a commit to colleenmcginnis/logstash that referenced this pull request Jul 28, 2025
colleenmcginnis added a commit to colleenmcginnis/logstash that referenced this pull request Jul 28, 2025
colleenmcginnis added a commit to colleenmcginnis/logstash that referenced this pull request Jul 28, 2025
colleenmcginnis added a commit that referenced this pull request Aug 14, 2025
* add applies_to badge to changes introduced in #17351

* add applies_to badge to changes introduced in #17759

* reorder list items

* use 9.0.1 not 9.1.0

* Update docs/reference/keystore.md

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: Karen Metts <[email protected]>
mergify bot pushed a commit that referenced this pull request Aug 14, 2025
* add applies_to badge to changes introduced in #17351

* add applies_to badge to changes introduced in #17759

* reorder list items

* use 9.0.1 not 9.1.0

* Update docs/reference/keystore.md

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit aed28eb)
colleenmcginnis added a commit that referenced this pull request Aug 14, 2025
* add applies_to badge to changes introduced in #17351

* add applies_to badge to changes introduced in #17759

* reorder list items

* use 9.0.1 not 9.1.0

* Update docs/reference/keystore.md



---------


(cherry picked from commit aed28eb)

Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clean up PQ queue.checkpoint.interval

3 participants