Fix deprecation warning with latest jruby/bundler #17766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the pluginmanager to not use a deprecated argument. See rubygems/rubygems@d1963bf
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
|
Kicked off exhaustive tests too https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2048 |
💛 Build succeeded, but was flaky
Failed CI Steps |
yaauie
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
👍
While this isn't backward-compatible with Bundlers < v2.6.0 when the deprecation notice was introduced, those old bundlers aren't compatible with our current jruby runtime. I think we're in the clear.
|
@Mergifyio backport 9.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
This commit updates the pluginmanager to not use a deprecated argument. See rubygems/rubygems@d1963bf (cherry picked from commit 443e527)
5 tasks
donoghuc
added a commit
that referenced
this pull request
Jul 1, 2025
This commit updates the pluginmanager to not use a deprecated argument. See rubygems/rubygems@d1963bf (cherry picked from commit 443e527) Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This commit updates the pluginmanager to not use a deprecated argument.
See rubygems/rubygems@d1963bf
Why is it important/What is the impact to the user?
Without this patch use of the plugin manager can surface warnings that are not actionable by the logstash user. This commit fixes the underlying issue so messages are no longer surfaced.
Checklist
Related issues
Logs