Skip to content

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Jul 7, 2025

That was originally pinned with: #17487

The pin was deletede on accident https://github.com/elastic/logstash/pull/17696/files it looks like this was due to it being nestled in between two pins that were supposed to be deleted.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@donoghuc donoghuc added the backport-skip Skip automated backport with mergify label Jul 7, 2025
Gemfile.template Outdated
gem "date", "= 3.3.3"
gem "thwait"
gem "bigdecimal", "~> 3.1"
gem "cgi", "~> 0.3.7" # Pins until a new jruby version with updated cgi is released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create either an issue or an actual PR on the jruby side bumping the dependency and linking it here in this comment? this way someone can just open the link and check if they can remove the pin or not (Assuming the merged PR was shipped in a jruby release)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! jruby/jruby#8919

I filed an issue to start and asked generally about what MRI ruby stream jruby is tracking for default gems.

This commit restores the cgi pin as the default in jruby is still 0.3.6.
@donoghuc donoghuc requested a review from jsvd July 16, 2025 17:33
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

@donoghuc donoghuc added backport-9.1 Automated backport to the 9.1 branch and removed backport-skip Skip automated backport with mergify labels Jul 17, 2025
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@donoghuc donoghuc added backport-skip Skip automated backport with mergify and removed backport-9.1 Automated backport to the 9.1 branch labels Jul 21, 2025
@donoghuc
Copy link
Member Author

Removed backport-9.1 label e53e161

@donoghuc donoghuc merged commit caf91cf into elastic:main Jul 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants