-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Restore cgi pin #17774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore cgi pin #17774
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
4ff58f7
to
964bd32
Compare
Gemfile.template
Outdated
gem "date", "= 3.3.3" | ||
gem "thwait" | ||
gem "bigdecimal", "~> 3.1" | ||
gem "cgi", "~> 0.3.7" # Pins until a new jruby version with updated cgi is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create either an issue or an actual PR on the jruby side bumping the dependency and linking it here in this comment? this way someone can just open the link and check if they can remove the pin or not (Assuming the merged PR was shipped in a jruby release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! jruby/jruby#8919
I filed an issue to start and asked generally about what MRI ruby stream jruby is tracking for default gems.
This commit restores the cgi pin as the default in jruby is still 0.3.6.
964bd32
to
6a77d8e
Compare
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Removed backport-9.1 label e53e161 |
That was originally pinned with: #17487
The pin was deletede on accident https://github.com/elastic/logstash/pull/17696/files it looks like this was due to it being nestled in between two pins that were supposed to be deleted.