Skip to content

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Jul 8, 2025

Release notes

[rn:skip]

What does this PR do?

Harmonize the testing of observability SRE container artifacts:

  1. Make sure container orchestration is happening at rspec level (previously both gradle and rspec)
  2. Share orchestration and ES interaction code in rspec
  3. Make dynamically interpolating values in docker compose manifests standardize and ensure the stack is the same as logstash version
  4. Simplify and document running the tests for local dev work.

Why is it important/What is the impact to the user?

NA

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

donoghuc added 4 commits July 8, 2025 12:41
Make rspec responsible for container orchestration. DRY shared functionality.
Dynamically look up the version of logstash and test against the corresponding ES image.
Also, extract this to make local dev easier.
@donoghuc
Copy link
Member Author

donoghuc commented Jul 8, 2025

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@donoghuc
Copy link
Member Author

donoghuc commented Jul 9, 2025

Acceptance tests are green on this!

Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM

@donoghuc donoghuc merged commit 1195743 into elastic:8.19 Aug 18, 2025
7 checks passed
@donoghuc
Copy link
Member Author

@Mergifyio backport main

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2025

backport main

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 18, 2025
* Move ES config from ENV to file

* Use fips filebeat impl for smoke tests

* Standardize container orchestration

Make rspec responsible for container orchestration. DRY shared functionality.

* Ensure we test against the right versions

Dynamically look up the version of logstash and test against the corresponding ES image.
Also, extract this to make local dev easier.

(cherry picked from commit 1195743)
donoghuc added a commit that referenced this pull request Aug 21, 2025
* Harmonize observability sre acceptance (#17781)

* Move ES config from ENV to file

* Use fips filebeat impl for smoke tests

* Standardize container orchestration

Make rspec responsible for container orchestration. DRY shared functionality.

* Ensure we test against the right versions

Dynamically look up the version of logstash and test against the corresponding ES image.
Also, extract this to make local dev easier.

(cherry picked from commit 1195743)

* Pin elasticsearch-cloud-fips image to 8.19.3

There is a bug in the 9.2.0 series of ES fips preventing us from using it in CI
Pin to 8.19.3 for now.

* WIP: test configuration

Explicitly require fips provider and use fipsmode

* Fix issues with filebeat and default to 9.2 (main) stack

This commit updates filebeat to use the 9 series format and increases the
log size with new minimum 1024 char size to start streaming. This also updates
the default stack version to 9.2 (currently that is version that tracks main)
and adds some more logging to help see what is going on during docker-compose and
wait.

* Apply updates to acceptance tests

---------

Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants