Skip to content

Run tests with jruby 9.4.13.0 #17798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Run tests with jruby 9.4.13.0 #17798

merged 1 commit into from
Jul 16, 2025

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc added the backport-9.1 Automated backport to the 9.1 branch label Jul 10, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@donoghuc donoghuc mentioned this pull request Jul 10, 2025
Merged
@donoghuc
Copy link
Member Author

Turns out this effort ended up being a bit of a red herring (see #17787 (comment) for details). HOWEVER it DOES align with current patterns, and probably the path of least resistance is to merge this while we figure out our long term plan around gem environments in CI.

I would like to investigate/propose NOT INSTALLING JRUBY AT ALL pre loaded on CI images. The only reason this was failing was shelling out to ruby to build test gems picked up rbenv on the path on the CI runner. This is not necessary at all as we explicitly download a suitable jruby environment for every set of tests.

@yaauie
Copy link
Member

yaauie commented Jul 10, 2025

I would like to investigate/propose NOT INSTALLING JRUBY AT ALL pre loaded on CI images

💯

@donoghuc
Copy link
Member Author

Filed https://github.com/elastic/ingest-dev/issues/5827 as part of CI improvement grouping.

@donoghuc donoghuc mentioned this pull request Jul 14, 2025
Merged
jsvd
jsvd approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regardless of eventually removing the need to have an external jruby, +1 on keeping this in sync with the bundled version of jruby, LGTM

@donoghuc donoghuc merged commit 9583f04 into elastic:main Jul 16, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Jul 16, 2025
@donoghuc @mergify
Run tests with jruby 9.4.13.0 (#17798)
1ab2d61 
Now that https://github.com/elastic/ci-agent-images/pull/1573 is merged
and promoted https://buildkite.com/elastic/vm-images-platform-ingest/builds/966
run tests with 9.4.13.0.

(cherry picked from commit 9583f04)
@mergify mergify bot mentioned this pull request Jul 16, 2025
Merged
donoghuc added a commit that referenced this pull request Jul 29, 2025
@mergify @donoghuc
Run tests with jruby 9.4.13.0 (#17798) (#17829)
df3808e 
Now that https://github.com/elastic/ci-agent-images/pull/1573 is merged
and promoted https://buildkite.com/elastic/vm-images-platform-ingest/builds/966
run tests with 9.4.13.0.

(cherry picked from commit 9583f04)

Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsvd jsvd jsvd approved these changes

Assignees

No one assigned

Labels

backport-9.1 Automated backport to the 9.1 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@donoghuc @elasticmachine @yaauie @jsvd