[CI] Remove UBI docker acceptance test

[kaisecheng]

This commit removes the UBI acceptance test.
The default base image is UBI. Full flavour test has covered UBI flavour

Fixes: #17830

This commit removes the unwanted warning which pollutes the plugins list

installed_plugins is polluted with ["pass JVM parameters via LS_JAVA_OPTS", "logstash-codec-avro", "logstash-codec-cef", ... ]

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
• If no backport is necessary, please add the backport-skip label

[donoghuc]

hmm, something must have changed in the UBI image? If that base image is setting JAVA_OPTS I think any consumer of the container would get an annoying message every time they use logstash. Maybe we should unset that in the container build process?

[donoghuc]

Also, is it expected that we run the trim task for containers other than observability SRE?

[donoghuc]

Not seeing it set in the ubi base

➜  build git:(restore-cgi-pin) ✗ docker image ls
REPOSITORY                                                     TAG               IMAGE ID       CREATED          SIZE
redhat/ubi9-minimal                                            latest            6d5a6576c838   28 hours ago     151MB
➜  build git:(restore-cgi-pin) ✗ docker run -it 6d5a6576c838 /bin/bash
[root@251cbbf98cae /]# echo $JAVA_OPTS

[root@251cbbf98cae /]# printenv | grep JAVA

[kaisecheng]

Since v9, the full / default image use UBI as base image, so "full flavour acceptance" has covered UBI in main. The failures are from all docker test, which is mapped to "ubi flavour acceptance". I think we should clean up UBI from exhaustive test for main and v9

For v8, the "full" use Ubuntu as base image and UBI flavour is still available.

[donoghuc]

If this warning is being printed, that means the environment has a legitimate issue IMO. JAVA_HOME should not be set, if it is somewhere in our build process (or even worse our final container artifacts) we should find that and fix it. Ignoring it here seems to be papering over a real problem.

[kaisecheng]

The issue is not related to JAVA_HOME, but rather to JAVA_OPTS

I don't think any base image set JAVA_OPTS. It is the project bash script running in some repeated way in "all docker tests" and set the JAVA_OPTS, probably here

Maybe "all docker tests" was part of the CI in the past, but it is not anymore.

Just confirmed the CI has passed the failing point by removing this line. But I am going to revert it, because UBI test should be removed

[donoghuc]

Sorry, i meant JAVA_OPTS that was a typo, i was also looking at JAVA_HOME for something else 🤦

The ubi removal makes sense!

[kaisecheng]

Waiting CI to be green https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2122

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 59e490b

History

• 💚 Build #3156 succeeded b191e70
• 💚 Build #3155 succeeded 1e9e2a1

[github-actions]

@Mergifyio backport 9.0 9.1

[mergify]

backport 9.0 9.1

✅ Backports have been created

• #17831 [9.0] (backport #17828) [CI] Remove UBI docker acceptance test has been created for branch 9.0
• #17832 [9.1] (backport #17828) [CI] Remove UBI docker acceptance test has been created for branch 9.1