-
Notifications
You must be signed in to change notification settings - Fork 3.5k
adding x-metatags to openapi spec #17854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @georgewallace? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit bc4645c) # Conflicts: # docs/static/spec/openapi/logstash-api.yaml
(cherry picked from commit bc4645c) # Conflicts: # docs/static/spec/openapi/logstash-api.yaml
(cherry picked from commit bc4645c) # Conflicts: # docs/static/spec/openapi/logstash-api.yaml
(cherry picked from commit bc4645c)
@georgewallace this PR spawned a few backport PRs that are still open, can you merge them too? thanks |
Release notes
What does this PR do?
This PR updates the OpenAPI spec to add the x-metatags extension. This extension adds product_name metadata which during docs build time is converted to a meta tag on the HTML page, this tag is then parsed by our internal site search to add the API docs pages to the product facets on search.
Why is it important/What is the impact to the user?
This allows users to filter their search by logstash and only see logstash apis
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs