Skip to content

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jul 28, 2025

Release notes

[rn:skip]

What does this PR do?

  • Update Collector#push to avoid dynamic dispatch of method invocation, explicitly invoke set on Gauge and increment on Counter.
  • Remove Ruby classes Gauge and Counter replacing by existing Java classes LongCounter and LazyDelegatingGauge which was wrapped by Ruby ones.

Why is it important/What is the impact to the user?

As a developer I want to have less context switch as possible when navigating metrics collection code.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

@andsel andsel self-assigned this Jul 28, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@andsel andsel marked this pull request as ready for review July 31, 2025 09:32
@andsel andsel requested a review from jsvd August 4, 2025 15:49
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor code style suggestion, otherwise lgtm

@andsel andsel requested a review from jsvd August 5, 2025 13:19
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green

@andsel andsel force-pushed the fix/remove_gauge_and_counter_ruby_classes branch from 74d2781 to a3ea2ff Compare August 5, 2025 16:55
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andsel

@andsel andsel merged commit 1d565c0 into elastic:main Aug 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants