-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Removal of Ruby bridge classes for Gauge and Counter #17858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of Ruby bridge classes for Gauge and Counter #17858
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor code style suggestion, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green
… explicitly invokce set on Gauge and increment on Counter
… and LazyDelegatingGauge instead of Ruby Gauge
Co-authored-by: João Duarte <[email protected]>
74d2781
to
a3ea2ff
Compare
|
💚 Build Succeeded
History
cc @andsel |
Release notes
[rn:skip]
What does this PR do?
Collector#push
to avoid dynamic dispatch of method invocation, explicitly invoke set on Gauge and increment on Counter.Why is it important/What is the impact to the user?
As a developer I want to have less context switch as possible when navigating metrics collection code.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues