make sure versions.yml is only read once into gradle.ext #17865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
|
💚 Build Succeeded
|
andsel
requested changes
Jul 29, 2025
There was a problem hiding this comment.
I like the idea to avoid duplication.
I tried with the input java test plugin (https://github.com/logstash-plugins/logstash-input-java_input_example) and ./gradlew clean test fails with:
FAILURE: Build failed with an exception.
* Where:
Script '/Users/andrea/workspace/logstash_andsel/rubyUtils.gradle' line: 27
* What went wrong:
A problem occurred evaluating script.
> Cannot get property 'versions' on extra properties extension as it does not exist
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 3s
We have to understand if we want to support that example or not.
|
@andsel I've addressed the java plugin issue by tweaking the plugin's build.gradle here logstash-plugins/logstash-input-java_input_example#19 This would have to be replicated to the other example plugins. I couldn't find a more elegant solution, unfortunately. |
This was referenced Aug 1, 2025
jsvd
added
backport-9.0
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle
It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs.
(cherry picked from commit b430599)
# Conflicts:
# rubyUtils.gradle
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle
It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs.
(cherry picked from commit b430599)
# Conflicts:
# rubyUtils.gradle
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle
It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs.
(cherry picked from commit b430599)
This was referenced Aug 1, 2025
jsvd
added a commit
to jsvd/logstash
that referenced
this pull request
Aug 1, 2025
this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle
It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs.
jsvd
added a commit
that referenced
this pull request
Aug 4, 2025
…7901) this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs. (cherry picked from commit b430599) Co-authored-by: João Duarte <[email protected]>
jsvd
added a commit
that referenced
this pull request
Aug 4, 2025
… gradle.ext (#17900) * make sure versions.yml is only read once into gradle.ext (#17865) this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs. (cherry picked from commit b430599) # Conflicts: # rubyUtils.gradle * Update rubyUtils.gradle --------- Co-authored-by: João Duarte <[email protected]>
jsvd
added a commit
that referenced
this pull request
Aug 4, 2025
…o gradle.ext (#17899) * make sure versions.yml is only read once into gradle.ext (#17865) this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle It uses gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any other buildscript {} block runs. (cherry picked from commit b430599) # Conflicts: # rubyUtils.gradle * Update rubyUtils.gradle * Update build.gradle * Update build.gradle --------- Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the need to re-read the yaml file in so many places, and also avoids having to state the jruby version an extra time in the rubyUtils.gradle
It uses
gradle.ext, computed in settings.gradle, as a place to store the versions. This is important to load the versions before any otherbuildscript {}block runs. From what I can gleam this isn't an anti-pattern, but happy to be convinced otherwise.Exhaustive test suite: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2179/steps/canvas