Skip to content

Conversation

theletterf
Copy link
Contributor

Removing exceedingly cheerful language (I'm the Grinch today).

Removing exceedingly cheerful language (I'm the Grinch today).
@theletterf theletterf self-assigned this Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@theletterf theletterf added the docs label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

🔍 Preview links for changed docs

@theletterf theletterf merged commit fc24c0a into 9.1 Aug 7, 2025
13 checks passed
@theletterf theletterf deleted the theletterf-patch-1 branch August 7, 2025 07:49
@jsvd
Copy link
Member

jsvd commented Aug 7, 2025

@theletterf Why was this PR created against 9.1 and not main? and not ported to 9.0 after merging? Also PRs and therefore commit messages should have a meaningful explanation of the change and not left as the default given by github.

@theletterf
Copy link
Contributor Author

@jsvd 100% agree. This was a drive-by edit. Adding backporting labels now.

@theletterf theletterf added backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch labels Aug 7, 2025
@theletterf
Copy link
Contributor Author

@Mergifyio backport main 9.0

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2025

backport main 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2025
Removing exceedingly cheerful language (I'm the Grinch today).

(cherry picked from commit fc24c0a)
mergify bot pushed a commit that referenced this pull request Aug 7, 2025
Removing exceedingly cheerful language (I'm the Grinch today).

(cherry picked from commit fc24c0a)
theletterf added a commit that referenced this pull request Aug 7, 2025
Removing exceedingly cheerful language (I'm the Grinch today).

(cherry picked from commit fc24c0a)

Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
theletterf added a commit that referenced this pull request Aug 7, 2025
Removing exceedingly cheerful language (I'm the Grinch today).

(cherry picked from commit fc24c0a)

Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants