[8.19] (backport #17958) Add fips config to jvm.options for observabilitySRE #17971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
* Add fips config to jvm.options for observabilitySRE In addition to setting `LS_JAVA_OPTS` we now include the fips config java options in the `/usr/share/logstash/config/jvm.options` file. This ensures that if consumers of the image overwrite `LS_JAVA_OPTS` the fips config is still respected from `jvm.options`. * *only* set jvm opts via jvm.options Stop setting LS_JAVA_OPTS in favor of jvm.options. * Use subshell to clean up file concat Codereview suggestion (cherry picked from commit 64e6462)
|
💚 Build Succeeded
cc @donoghuc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
In addition to setting
LS_JAVA_OPTSwe now include the fips config java options in the/usr/share/logstash/config/jvm.optionsfile. This ensures that if consumers of the image overwriteLS_JAVA_OPTSthe fips config is still respected fromjvm.options.Related Issues
This is an automatic backport of pull request Add fips config to jvm.options for observabilitySRE #17958 done by Mergify.