Preserve coerce behavior from Ruby Integer/PositiveInteger Settings impl #17992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently elastic#17460 the implementation for integer/postive integer settings was moved from jruby to pure java. The ruby implementation was leinient with whitespace in string values. This commit updates the java implementation to replicate this by stripping whitespace from string values before trying to parse them as int.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
donoghuc
changed the title
|
Ruby: |
1 task
|
💚 Build Succeeded
|
Health report tests are green when run against this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Recently #17460 the implementation for integer/postive integer settings was moved from jruby to pure java. The ruby implementation was leinient with whitespace in string values. This commit updates the java implementation to replicate this by stripping whitespace from string values before trying to parse them as int.