Skip to content

fixing thin and zero width white space characters in docs #18019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

fixing thin and zero width white space characters in docs #18019

merged 1 commit into from
Aug 22, 2025

Conversation

georgewallace
Copy link
Contributor

@georgewallace georgewallace commented Aug 22, 2025 •
edited
Loading

Fixing Zero width and thin space white space in the docs that keep showing github errors when creating PRs

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025

This pull request does not have a backport label. Could you fix it @georgewallace? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions
Copy link
Contributor

🔍 Preview links for changed docs

karenzone
karenzone approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@georgewallace georgewallace added backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch labels Aug 22, 2025
@georgewallace georgewallace merged commit 5f7a6cd into main Aug 22, 2025
13 checks passed
@georgewallace georgewallace deleted the whitespace branch August 22, 2025 21:39
mergify bot pushed a commit that referenced this pull request Aug 22, 2025
@georgewallace @mergify
fixing thin and zero width white space characters in docs (#18019)
8722e8e 
(cherry picked from commit 5f7a6cd)
@mergify mergify bot mentioned this pull request Aug 22, 2025
Open
mergify bot pushed a commit that referenced this pull request Aug 22, 2025
@georgewallace @mergify
fixing thin and zero width white space characters in docs (#18019)
9ef6da3 
(cherry picked from commit 5f7a6cd)
@mergify mergify bot mentioned this pull request Aug 22, 2025
Open
donoghuc added a commit to donoghuc/logstash that referenced this pull request Sep 3, 2025
@donoghuc
Ensure any file object in a tar archive has an mtime
a493fa1 
Following up on elastic#18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from elastic#18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.
@donoghuc donoghuc mentioned this pull request Sep 3, 2025
Merged
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
ef97a87 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
2c1119f 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
553ff70 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
6918320 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
89f0002 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@donoghuc @jsvd
Ensure any file object in a tar archive has an mtime (#18113)
8e35ee0 
* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@mergify @donoghuc @jsvd
[8.17] (backport #18091) Preserve mtime explicitly when creating tar …
cae0721 
…artifacts (#18108)

* Preserve mtime explicitly when creating tar artifacts (#18091)

* Preserve mtime explicitly when creating tar artifacts

When building tar archives, explicitly set mtime. This avoids losing that
information in the minitar `Writer.add_file_simple` method
 https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139

* Better default for mtime

If for some reason we cant get a time from a File object (very unlikely)
a better default is Time.now rather than 0.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit d9b95bf)

# Conflicts:
#	rakelib/artifacts.rake

* Ensure any file object in a tar archive has an mtime (#18113)

* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <[email protected]>
Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@mergify @donoghuc @jsvd
[8.18] (backport #18091) Preserve mtime explicitly when creating tar …
b92aa3d 
…artifacts (#18109)

* Preserve mtime explicitly when creating tar artifacts (#18091)

* Preserve mtime explicitly when creating tar artifacts

When building tar archives, explicitly set mtime. This avoids losing that
information in the minitar `Writer.add_file_simple` method
 https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139

* Better default for mtime

If for some reason we cant get a time from a File object (very unlikely)
a better default is Time.now rather than 0.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit d9b95bf)

# Conflicts:
#	rakelib/artifacts.rake

* Ensure any file object in a tar archive has an mtime (#18113)

* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <[email protected]>
Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@mergify @donoghuc @jsvd
[9.0] (backport #18091) Preserve mtime explicitly when creating tar a…
36b0d53 
…rtifacts (#18111)

* Preserve mtime explicitly when creating tar artifacts (#18091)

* Preserve mtime explicitly when creating tar artifacts

When building tar archives, explicitly set mtime. This avoids losing that
information in the minitar `Writer.add_file_simple` method
 https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139

* Better default for mtime

If for some reason we cant get a time from a File object (very unlikely)
a better default is Time.now rather than 0.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit d9b95bf)

# Conflicts:
#	rakelib/artifacts.rake

* Ensure any file object in a tar archive has an mtime (#18113)

* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <[email protected]>
Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@mergify @donoghuc @jsvd
[9.1] (backport #18091) Preserve mtime explicitly when creating tar a…
9d8ab4c 
…rtifacts (#18112)

* Preserve mtime explicitly when creating tar artifacts (#18091)

* Preserve mtime explicitly when creating tar artifacts

When building tar archives, explicitly set mtime. This avoids losing that
information in the minitar `Writer.add_file_simple` method
 https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139

* Better default for mtime

If for some reason we cant get a time from a File object (very unlikely)
a better default is Time.now rather than 0.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit d9b95bf)

# Conflicts:
#	rakelib/artifacts.rake

* Ensure any file object in a tar archive has an mtime (#18113)

* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <[email protected]>
Co-authored-by: João Duarte <[email protected]>
donoghuc added a commit that referenced this pull request Sep 4, 2025
@mergify @donoghuc @jsvd
[8.19] (backport #18091) Preserve mtime explicitly when creating tar …
c30c386 
…artifacts (#18110)

* Preserve mtime explicitly when creating tar artifacts (#18091)

* Preserve mtime explicitly when creating tar artifacts

When building tar archives, explicitly set mtime. This avoids losing that
information in the minitar `Writer.add_file_simple` method
 https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139

* Better default for mtime

If for some reason we cant get a time from a File object (very unlikely)
a better default is Time.now rather than 0.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit d9b95bf)

* Ensure any file object in a tar archive has an mtime (#18113)

* Ensure any file object in a tar archive has an mtime

Following up on #18091, when minitar
writes a directory or symlink it also needs explicit mtime. After inspecting
artifacts built from #18019 we see some other missing mtimes. This commit
ensures that information is explicitly passed to the minitar writer.

* Update rakelib/artifacts.rake

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: Cas Donoghue <[email protected]>
Co-authored-by: João Duarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenzone karenzone karenzone approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

Assignees

No one assigned

Labels

backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch docs Team:Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgewallace @karenzone