Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 28, 2025

Release notes

[rn:skip]

What does this PR do?

Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on.

Why is it important/What is the impact to the user?

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues


This is an automatic backport of pull request #17995 done by [Mergify](https://mergify.com).

* Build artifacts only for those that match host arch

Previously when doing platform specific builds (x86_64, arm) BOTH sets of
artifacts were produced regarless of host. This increases CI run times and
is needless resource consumption. This commit makes the rake tasks compile
artifacts for only the host arch it is being run on.

* set ARCH for building observabilitysre image

* Parallelize system package steps across different build hosts

This follows the pattern for prepping docker artifacts by preparing artifacts
for a target architecture on a specific build host. This allows us to process
x86 and arm packages in parallel across builders. Note that there is no
requirement today for the system packages to be built on an arch that matches
the target, spearating out to a separate builder opens up that opportunity for
us though.

(cherry picked from commit f2e4948)

# Conflicts:
#	.buildkite/pull_request_pipeline.yml
#	rakelib/artifacts.rake
@mergify mergify bot added backport conflicts Detected git conflicts labels Aug 28, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Aug 28, 2025

Cherry-pick of f2e4948 has failed:

On branch mergify/bp/8.17/pr-17995
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit f2e49484.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/scripts/dra/generatesteps.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/pull_request_pipeline.yml
	both modified:   rakelib/artifacts.rake

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Contributor Author

mergify bot commented Sep 1, 2025

This pull request has not been merged yet. Could you please review and merge it @donoghuc? 🙏

…8079)

* Ensure acceptance test artifacts are being built for correct arch

With the improvment in #17995 we only
build packages that match the architecture of the host. This is specified with
an enviornment variable. Previously the acceptance tests did not need to
specifcy the architecture when building packages. This commit updates the
builder to build packages with the correct arch.

* Ensure ARCH is set for docker acceptance tests
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @donoghuc

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@donoghuc donoghuc merged commit cace837 into 8.17 Sep 2, 2025
8 checks passed
@donoghuc donoghuc deleted the mergify/bp/8.17/pr-17995 branch September 2, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts Detected git conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants