Ensure acceptance test artifacts are being built for correct arch #18079
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the improvment in elastic#17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
Exhaustive test run: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2396 |
|
#18079 (comment) showed that the package based tests are fixed, kicked off a run to test the container based acceptance tests https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2409 |
|
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
|
Going to handle backports manually (as part of backporting the change that made this required in the first place). |
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…8079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…8079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…8079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…8079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…8079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…st arch (#18071) * Build artifacts only for those that match host arch (#17995) * Build artifacts only for those that match host arch Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on. * set ARCH for building observabilitysre image * Parallelize system package steps across different build hosts This follows the pattern for prepping docker artifacts by preparing artifacts for a target architecture on a specific build host. This allows us to process x86 and arm packages in parallel across builders. Note that there is no requirement today for the system packages to be built on an arch that matches the target, spearating out to a separate builder opens up that opportunity for us though. (cherry picked from commit f2e4948) # Conflicts: # .buildkite/pull_request_pipeline.yml # rakelib/artifacts.rake * fix merge conflicts * Ensure acceptance test artifacts are being built for correct arch (#18079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…st arch (#18073) * Build artifacts only for those that match host arch (#17995) * Build artifacts only for those that match host arch Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on. * set ARCH for building observabilitysre image * Parallelize system package steps across different build hosts This follows the pattern for prepping docker artifacts by preparing artifacts for a target architecture on a specific build host. This allows us to process x86 and arm packages in parallel across builders. Note that there is no requirement today for the system packages to be built on an arch that matches the target, spearating out to a separate builder opens up that opportunity for us though. (cherry picked from commit f2e4948) # Conflicts: # rakelib/artifacts.rake * fix merge conflicts * Ensure acceptance test artifacts are being built for correct arch (#18079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…t arch (#18074) * Build artifacts only for those that match host arch (#17995) * Build artifacts only for those that match host arch Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on. * set ARCH for building observabilitysre image * Parallelize system package steps across different build hosts This follows the pattern for prepping docker artifacts by preparing artifacts for a target architecture on a specific build host. This allows us to process x86 and arm packages in parallel across builders. Note that there is no requirement today for the system packages to be built on an arch that matches the target, spearating out to a separate builder opens up that opportunity for us though. (cherry picked from commit f2e4948) # Conflicts: # .buildkite/pull_request_pipeline.yml # rakelib/artifacts.rake * fix merge conflicts * Ensure acceptance test artifacts are being built for correct arch (#18079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…t arch (#18075) * Build artifacts only for those that match host arch (#17995) * Build artifacts only for those that match host arch Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on. * set ARCH for building observabilitysre image * Parallelize system package steps across different build hosts This follows the pattern for prepping docker artifacts by preparing artifacts for a target architecture on a specific build host. This allows us to process x86 and arm packages in parallel across builders. Note that there is no requirement today for the system packages to be built on an arch that matches the target, spearating out to a separate builder opens up that opportunity for us though. (cherry picked from commit f2e4948) # Conflicts: # .buildkite/pull_request_pipeline.yml # rakelib/artifacts.rake * fix merge conflicts * Ensure acceptance test artifacts are being built for correct arch (#18079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 2, 2025
…st arch (#18072) * Build artifacts only for those that match host arch (#17995) * Build artifacts only for those that match host arch Previously when doing platform specific builds (x86_64, arm) BOTH sets of artifacts were produced regarless of host. This increases CI run times and is needless resource consumption. This commit makes the rake tasks compile artifacts for only the host arch it is being run on. * set ARCH for building observabilitysre image * Parallelize system package steps across different build hosts This follows the pattern for prepping docker artifacts by preparing artifacts for a target architecture on a specific build host. This allows us to process x86 and arm packages in parallel across builders. Note that there is no requirement today for the system packages to be built on an arch that matches the target, spearating out to a separate builder opens up that opportunity for us though. (cherry picked from commit f2e4948) # Conflicts: # .buildkite/pull_request_pipeline.yml # rakelib/artifacts.rake * fix merge conflicts * Ensure acceptance test artifacts are being built for correct arch (#18079) * Ensure acceptance test artifacts are being built for correct arch With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch. * Ensure ARCH is set for docker acceptance tests * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With elastic#18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary.
donoghuc
added a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary.
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd)
donoghuc
added a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 8, 2025
This commit fixes the aarch64 acceptance tests. With #18079 a new env var was added to aarch64 docker acceptance tests. At that time the fact that the `command` was missing a block scalar `|` was missed. Thus the newlines were not respected and the script for preparing a vm agent was not executed correctly. This resulted in `bundle` command not being found on the test runner. This commit fixes the `command` section to include a block scalar. Additionally we stop waiting on unit tests before starting docker tests as this is unncessary. (cherry picked from commit 1e127fd) Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the improvment in #17995 we only build packages that match the architecture of the host. This is specified with an enviornment variable. Previously the acceptance tests did not need to specifcy the architecture when building packages. This commit updates the builder to build packages with the correct arch.