-
Notifications
You must be signed in to change notification settings - Fork 0
feat(terranova): support for bump #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fr4nc1sc0-r4m0n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # Only run e2e tests from the main branch as we need some credentials | ||
| # that we don't want to risk leaking from pullrequest opened by random contributors | ||
| if: github.ref == 'refs/heads/main' || ${{ inputs.run-e2e-tests }} | ||
| if: github.ref == 'refs/heads/main' || ( github.event_name == 'workflow_dispatch' && inputs.run-e2e-tests == true ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression, so I had to fix it otherwise it's always true
Tested manually https://github.com/elastic/oblt-updatecli-policies/actions/runs/18312529977/job/52144350325
fr4nc1sc0-r4m0n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.