Skip to content

split k8sattributes/ecs processor: do not add any extra metadata #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

split k8sattributes/ecs processor: do not add any extra metadata #46

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6859bb0
split k8sattributes/ecs processor: do not add any extra metadata
tetianakravchenko Nov 6, 2024
bb27128
add back name metadata
tetianakravchenko Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions resources/kubernetes/operator/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,13 @@ collectors:
name: k8s.pod.uid
- sources:
- from: connection
extract:
metadata:
- "k8s.replicaset.name"
Copy link
Contributor Author

@tetianakravchenko tetianakravchenko Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note:
for those fields translation happens on the es exporter side:

- "k8s.namespace.name"
- "k8s.deployment.name"
- "k8s.node.name"
- "k8s.pod.name"
- "k8s.pod.uid"

those fields were removed in comparison to k8sattributes for otel mode:

- "k8s.pod.ip"
- "k8s.pod.start_time"

Copy link
Contributor

@gizas gizas Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!
So clarification,
- "k8s.replicaset.name",
- "k8s.statefulset.name"
- "k8s.daemonset.name"
- "k8s.cronjob.name"
- "k8s.job.name"
will remain as is in the kubernetes.pod datastream. We dont have a unique naming convention, just saying !

- "k8s.statefulset.name"
- "k8s.daemonset.name"
- "k8s.cronjob.name"
- "k8s.job.name"
receivers:
# [OTLP Receiver](https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver)
otlp:
Expand Down