Skip to content

Update vale-linting.yml #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

Update vale-linting.yml #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/vale-linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,24 @@
name: Vale Documentation Linting

on:
pull_request_target: # ← This is the key change
types: [opened, synchronize, reopened]
pull_request:
paths:
- '**.md'
- '**.adoc'

permissions:
contents: read
pull-requests: write
pull-requests: write # Required for posting PR comments
Copy link
Member

@v1v v1v Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work as long as it's a PR from an upstream, otherwise it will not work for forked PRs

Copy link
Collaborator Author

@theletterf theletterf Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any solution to that?


jobs:
vale:
runs-on: ubuntu-latest
steps:
- name: Checkout PR branch
- name: Checkout
uses: actions/checkout@v5
with:
ref: ${{ github.event.pull_request.head.sha }} # ← Checkout the PR's code
fetch-depth: 0

- name: Run Elastic Vale Linter
uses: elastic/vale-rules@main
with:
Expand Down