-
Notifications
You must be signed in to change notification settings - Fork 36
document java supported technologies #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document java supported technologies #95
Conversation
Acrolinx ScorecardsSelect the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.
*TBD |
Acrolinx ScorecardsSelect the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.
*TBD |
Acrolinx ScorecardsSelect the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.
*TBD |
Acrolinx ScorecardsSelect the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.
*TBD |
Acrolinx ScorecardsSelect the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.
*TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments where I think it could help the reader.
| inherits all the features of the OpenTelemetry Java Instrumentation to capture logs, metrics and traces. | ||
|
|
||
| The EDOT Java agent also provides exclusive features that are _not available_ in the [OpenTelemetry Java Instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation) | ||
| or are provided but with different default configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be a bit more clear about to what the different default configuration refers to. Maybe starting a new sentence. I find a bit hard to read as it is at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| This extension provides the ability to enhance the traces by creating spans from [async-profiler](https://github.com/async-profiler/async-profiler) data without the need of explicit instrumentation of corresponding spans. | ||
|
|
||
| This feature is disabled by default and can be enabled by setting `OTEL_INFERRED_SPANS_ENABLED` to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this has any impact on the runtime environment and resources that should be mentioned here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure to understand, can you elaborate a bit ?
|
|
||
| ## Runtime metrics | ||
|
|
||
| Experimental runtime metrics are _enabled_ by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we better use "tech preview" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the 'experimental' comes from the upstream configuration option, so I think it's better to keep it as-is for now. We can maybe clarify this and add a link to semconv to help understand that it's because those are experimental in semconv.
|
|
||
| [Universal Profiling](https://www.elastic.co/observability/universal-profiling) integration provides the ability to correlate traces with profiling data from the Elastic universal profiler. | ||
|
|
||
| This feature is enabled by default on supported systems, disabled otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the supported systems? Following the link in line 58 I haven't found the answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know and haven't found a clear reference on this, I assume it's a combination of linux, kernel version and availability of binaries for the target architecture. This sentence was almost copied as-is from the existing docs.
The "features" page is the one we will can link to from a broader "feature matrix".