Migrate fleet output acceptance tests #1509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates fleet output acceptance tests to use a testdata directory structure instead of inline configuration strings. The changes align with current testing expectations by separating Terraform configurations into external files and using ConfigDirectory and ConfigVariables for test setup.
Key Changes
- Replaced inline test configuration strings with embedded testdata files
- Updated test steps to use
ConfigDirectoryandConfigVariablesinstead of inlineConfig - Removed helper functions that generated configuration strings (
testAccResourceOutputCreate*andtestAccResourceOutputUpdate*)
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/fleet/output/acc_test.go | Migrated test cases to use embedded testdata files and ConfigDirectory pattern; removed inline configuration helper functions |
| internal/fleet/output/testdata/TestAccResourceOutputElasticsearch/create/output.tf | New testdata file for Elasticsearch output create test case |
| internal/fleet/output/testdata/TestAccResourceOutputElasticsearch/create/variables.tf | Variable definition for Elasticsearch create test |
| internal/fleet/output/testdata/TestAccResourceOutputElasticsearch/update/output.tf | New testdata file for Elasticsearch output update test case |
| internal/fleet/output/testdata/TestAccResourceOutputElasticsearch/update/variables.tf | Variable definition for Elasticsearch update test |
| internal/fleet/output/testdata/TestAccResourceOutputElasticsearchFromSDK/create/output.tf | New testdata file for SDK-based Elasticsearch output test |
| internal/fleet/output/testdata/TestAccResourceOutputLogstash/create/output.tf | New testdata file for Logstash output create test case |
| internal/fleet/output/testdata/TestAccResourceOutputLogstash/create/variables.tf | Variable definition for Logstash create test |
| internal/fleet/output/testdata/TestAccResourceOutputLogstash/update/output.tf | New testdata file for Logstash output update test case |
| internal/fleet/output/testdata/TestAccResourceOutputLogstash/update/variables.tf | Variable definition for Logstash update test |
| internal/fleet/output/testdata/TestAccResourceOutputLogstashFromSDK/create/output.tf | New testdata file for SDK-based Logstash output create test |
| internal/fleet/output/testdata/TestAccResourceOutputLogstashFromSDK/update/output.tf | New testdata file for SDK-based Logstash output update test |
| internal/fleet/output/testdata/TestAccResourceOutputKafka/create/output.tf | New testdata file for Kafka output create test case |
| internal/fleet/output/testdata/TestAccResourceOutputKafka/create/variables.tf | Variable definition for Kafka create test |
| internal/fleet/output/testdata/TestAccResourceOutputKafka/update/output.tf | New testdata file for Kafka output update test case |
| internal/fleet/output/testdata/TestAccResourceOutputKafka/update/variables.tf | Variable definition for Kafka update test |
| internal/fleet/output/testdata/TestAccResourceOutputKafkaComplex/create/output.tf | New testdata file for complex Kafka output test case |
| internal/fleet/output/testdata/TestAccResourceOutputKafkaComplex/create/variables.tf | Variable definition for complex Kafka test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #836
Bringing this resource inline with the current expectations whilst I'm here.