Simplify configuration of the electric app #1889
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When electric is included as a dependency then the configuration done in our `config/runtime.exs` is not used, and the application needs to set electric up itself. Because we've made every configuration option required in the code (relying on runtime.exs) this is onerous. But, because every option except the db connection actually has sensible defaults, we can simplify this and reduce the required configuration settings down to the db connection stuff. The only downside to this is that now we have default values for the parameters in two locations, runtime.exs and with every `Application.get_env/3` call. I took the opportunity to re-factor the configuration stuff and move it out of the application.ex module.
magnetised
force-pushed
the
simplify-configuration
branch
from
bcce918
to
73e4c97
Compare
|
NOTE: I'm pausing this until the multi-tenant work is complete as the two have dangerous amounts of overlap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When electric is included as a dependency then the configuration done in our
config/runtime.exsis not used, and the application needs to set electric up itself.Because we've made every configuration option required in the code (relying on runtime.exs) this is onerous.
But, because every option except the db connection actually has sensible defaults, we can simplify this and reduce the required configuration settings down to the db connection stuff.
The only downside to this is that now we have default values for the parameters in two locations, runtime.exs and with every
Application.get_env/3call.I took the opportunity to re-factor the configuration stuff and move it out of the application.ex module.
TODO
config :electric, :storage_dir, "/my/path"