Skip to content

Conversation

nightrainlily
Copy link

Issue

Closes #7984

Description

Fixed translation issue (originally noted in French but persisted across languages) for layer toggles.

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the old keys that are no longer used as well?

@nightrainlily
Copy link
Author

@VIKTORVAV99 do you mean remove all the unused translation keys? ie button.reddit, button.twitter? just want to make sure before i delete

Comment on lines +41 to +63
const MENU_ITEMS = [
{
to: '/',
label: t('sidebar-menu.map'),
icon: MapIcon,
isActive: true,
},
{
label: t('sidebar-menu.datasets'),
to: `${PORTAL_URL}/datasets`,
icon: FileDownIcon,
},
{
label: t('sidebar-menu.api'),
to: `${PORTAL_URL}`,
icon: CodeXmlIcon,
},
{
label: t('sidebar-menu.api-docs'),
to: `${PORTAL_URL}/docs`,
icon: BookOpenIcon,
},
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't move these inside the component or translate them. They are designed to match our data portal which don't use translations as of now.

className="flex cursor-pointer select-none items-center rounded-sm px-2 py-1.5 outline-none hover:bg-neutral-100 focus:bg-neutral-100 dark:hover:bg-neutral-700 dark:focus:bg-neutral-700"
>
FAQ & Support
{t('button.faq')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

className="flex cursor-pointer select-none items-center rounded-sm px-2 py-1.5 outline-none hover:bg-neutral-100 focus:bg-neutral-100 dark:hover:bg-neutral-700 dark:focus:bg-neutral-700"
>
Chat With Us
{t('button.chat-with-us')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Comment on lines +42 to +48
"sidebar-menu": {
"map": "Map",
"datasets": "Datasets",
"api": "API",
"api-docs": "API Docs",
"helpMenu": "Help and Support Menu"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be using translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing french translations on the webapp while they exists in fr.json

2 participants