-
Notifications
You must be signed in to change notification settings - Fork 1k
fixed wind and solar layer translation issue #8063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the old keys that are no longer used as well?
@VIKTORVAV99 do you mean remove all the unused translation keys? ie button.reddit, button.twitter? just want to make sure before i delete |
const MENU_ITEMS = [ | ||
{ | ||
to: '/', | ||
label: t('sidebar-menu.map'), | ||
icon: MapIcon, | ||
isActive: true, | ||
}, | ||
{ | ||
label: t('sidebar-menu.datasets'), | ||
to: `${PORTAL_URL}/datasets`, | ||
icon: FileDownIcon, | ||
}, | ||
{ | ||
label: t('sidebar-menu.api'), | ||
to: `${PORTAL_URL}`, | ||
icon: CodeXmlIcon, | ||
}, | ||
{ | ||
label: t('sidebar-menu.api-docs'), | ||
to: `${PORTAL_URL}/docs`, | ||
icon: BookOpenIcon, | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't move these inside the component or translate them. They are designed to match our data portal which don't use translations as of now.
className="flex cursor-pointer select-none items-center rounded-sm px-2 py-1.5 outline-none hover:bg-neutral-100 focus:bg-neutral-100 dark:hover:bg-neutral-700 dark:focus:bg-neutral-700" | ||
> | ||
FAQ & Support | ||
{t('button.faq')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
className="flex cursor-pointer select-none items-center rounded-sm px-2 py-1.5 outline-none hover:bg-neutral-100 focus:bg-neutral-100 dark:hover:bg-neutral-700 dark:focus:bg-neutral-700" | ||
> | ||
Chat With Us | ||
{t('button.chat-with-us')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here.
"sidebar-menu": { | ||
"map": "Map", | ||
"datasets": "Datasets", | ||
"api": "API", | ||
"api-docs": "API Docs", | ||
"helpMenu": "Help and Support Menu" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be using translations.
Issue
Closes #7984
Description
Fixed translation issue (originally noted in French but persisted across languages) for layer toggles.
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.