-
Notifications
You must be signed in to change notification settings - Fork 1k
Enable multiple map colourings #8159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@tonypls it will probably make more sense for us to sit down for this in order to review. Do you know why two different typechecking actions are performed? Why not typecheck everything (frontend + scripts) in one go? cc @VIKTORVAV99 in case you have additional insights or ideas to bring to the table. |
I think for the typechecking it's different because the scripts include node APIs in the default types (the ones you don't need to import) and the frontend includes the Vite types neither are available in the others environment. Not sure if there is a easy fix but you can always mock the color object that is used if needed. |
I can take a look at reviewing this later today/tomorrow but I have a massive PR from the hack to review + update the API so not sure if I'll actually have time. |
Would love some guidance / ideas here when you have time! |
cc @madsnedergaard given that this PR also contains code that updates the arrow generation scripts (images were outdated and the script didn't output the optimised webp files). |
Issue
Description
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.