fix: resolve missing logo asset #8196
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| <p align="center"> | |||
| <a href="https://app.electricitymaps.com"> | |||
| <img alt="Electricity Maps" src="https://raw.githubusercontent.com/electricitymaps/electricitymaps-contrib/master/web/public/images/electricitymaps-logo.svg" width="100" /> | |||
| <img alt="Electricity Maps" src="https://raw.githubusercontent.com/electricitymaps/electricitymaps-contrib/master/web/public/images/electricity-maps-logo.svg" width="100" /> | |||
There was a problem hiding this comment.
Looks good but I think we might want to use the social images instead, the dark and light versions so we can switch between the two on github depending on the user preference. Right now you can hardly see the logo on dark mode.
There was a problem hiding this comment.
Thanks for the feedback! Should I update the PR to use the social images with support for light/dark mode? Where can I find them? Let me know how I can help move this forward or what to do with this PR for now.
There was a problem hiding this comment.
@Alportan do you know where the social images are so @emmanuel-ferdman can use them instead?
There was a problem hiding this comment.
I remember vaguely talking to Viktor about it a while ago, and I believe it should be these ones 👇
There was a problem hiding this comment.
@Alportan The light and dark versions of the ElectricityMap social image are included in the README.md. Just above them, we also display the ElectricityMap logo, which currently only exists in light mode. Viktor suggested adding a dark mode version of the logo as well. If the dark mode logo asset doesn't exist, we can keep the light mode to fix the broken link for now (or just remove the logo section), until we will have a dark mode logo as well. 😄
Here is the logo:
There was a problem hiding this comment.
Ah, I misunderstood. here's the logo for dark mode
There was a problem hiding this comment.
@emmanuel-ferdman does that image work for you?
|
Hi @VIKTORVAV99, can you please update what shall we do with this PR? thanks 🙌 |
|
@emmanuel-ferdman I'll take over the review because Viktor is out. |
Issue
Description
This small PR fixes the broken missing logo asset in
README.md.Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.