-
Notifications
You must be signed in to change notification settings - Fork 1k
Add updated YUKONENERGY for CA-YT #8277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise I don't see any issues, but this is a GPZD zone and I don't know what the protocol is for how and what to do when we switch to live data again.
Would be good to get @PaulRoms, @seljaks and @BastienBigue input on this as I'm afraid we might overwrite all the GPZD data we have with TSA if we just switch it outright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad to see the documenting comments go 🤔
Is there any historical data available for this parser? Regarding GPZD and TSA, you are right @VIKTORVAV99 that is might not work as expected. The idea solution, if we don't have historical data would be to enable GPZD until a certain point and then the TSA takes from here |
Only the last 24 hours, so we can't backfill any data. Currently I don't think the estimator has a way of configuring GPZD only for some duration so it's a all or nothing approach right now. We'd have to change how the estimator is configured if we wanted to change that. It would probably be a good change as there are other zones we could enable it for ass well that only have partial measured data. |
Agree with you! Let me ask the team :) |
Issue
Update / add parser for CA-YT.
Description
There was a parser before but it was not in use and outdated. It has now been updated. The data is fetched directly from the html response. We get data for the past 24 hours (hourly) and for the past 5 minutes.
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.