feat(testing): Add unit tests for EMBER production mode mapper #8480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Nov 3, 2025
Member
VIKTORVAV99
left a comment
VIKTORVAV99
left a comment
There was a problem hiding this comment.
Thanks for the PR but please make sure all tests are passing and all comments are in english.
Member
There was a problem hiding this comment.
Please make sure that all comments are in english and remove the CT1, CT2 titles from the comments, they don't relate what is being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR introduces a comprehensive test suite for the _ember_production_mode_mapper helper function in the Ember capacity parser.
Changes:
Added Unit Tests: A new test file with 7 test cases has been created to validate the function's logic. These tests were designed using the Modified Condition/Decision Coverage (MC/DC) criterion.
Achieved 100% Coverage for the Target Function: The new tests provide 100% code coverage for the _ember_production_mode_mapper function itself, raising the file's overall coverage from 24% to 39%.
Bug Fix: A bug was identified and fixed during the testing process. The function would previously raise an UnboundLocalError if the input mode was not a string (e.g., None). It now correctly handles this edge case and returns None.
This contribution should increase the reliability and maintainability of the Ember parser.
Thank you for your time and review!