Fix ICM20948 ReadExternalRegister argument count#686
Merged
stephenhensley merged 1 commit intoelectro-smith:masterfrom Feb 19, 2026
Merged
Conversation
Problem: ReadExternalRegister() calls AuxillaryRegisterTransaction() with 3 arguments, but the function expects 4 (read, slv_addr, reg_addr, value). This causes compilation errors when using magnetometer functionality. Solution: Pass 0 as the 4th argument for read operations. The value parameter is only used for write operations, so passing 0 for reads is safe. Testing: - Verified compilation succeeds with this fix - Magnetometer initialization now works correctly - No impact on other ICM20948 functionality Files Changed: - src/dev/icm20948.h (line 686): Added missing 4th argument (0)
Collaborator
|
Sneaky error, there. I confirmed the error, and that your patch fixes it. Thanks for the contribution! |
|
@Brokezawa I have these sensors here but have not been able to get them to work. Any clue to how we should connect these? Do they require level conversion? |
Contributor
Author
|
Sorry I don't have one on hand right now, I just happened to stumble across this error while building my Nim wrapper for libDaisy. Maybe look into the Adafruit guide for more info : https://learn.adafruit.com/adafruit-tdk-invensense-icm-20948-9-dof-imu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
ReadExternalRegister() calls AuxillaryRegisterTransaction() with 3 arguments, but the function expects 4 (read, slv_addr, reg_addr, value). This causes compilation errors when using magnetometer functionality.
Solution:
Pass 0 as the 4th argument for read operations. The value parameter is only used for write operations, so passing 0 for reads is safe.
Testing:
Files Changed: