-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use electron-winstaller instead of self module #8344
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8e2086f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for car-park-attendant-cleat-11576 failed.
|
Is this package actually still supported by the electron team? Many packages in that org have been dead for a long time. |
That's a great point. @beyondkmp what bug fixes is this solving for? (Can't tell from the description) |
@Stanzilla looks like updates are still being pushed to |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
* The custom squirrel.windows.exe path. Defaults to `https://github.com/electron-userland/electron-builder-binaries/tree/master/Squirrel.Windows`. | ||
*/ | ||
readonly vendorDirectory?: string | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update doc comment
/**
* The custom file path to `squirrel.windows.exe` for usage with [electron-winstaller](https://github.com/electron/windows-installer) `vendorDirectory`.
*/
Defaults to
https://github.com/electron-userland/electron-builder-binaries/tree/master/Squirrel.Windows
Also, is this true with the current setup? I don't see any default value being set for vendorDirectory
. As this is currently coded, it looks like it'll default to the vendor files that come with electron/windows-installer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
/**
* The custom squirrel.windows.exe path. If not specified will use the Squirrel.Windows that is shipped with electron-installer(https://github.com/electron/windows-installer/tree/main/vendor).
* After https://github.com/electron-userland/electron-builder-binaries/pull/56 merged, will add `electron-builder-binaries` to get the latest version of squirrel.
*/
The squirrel windows in this electron-userland/electron-builder-binaries#56 is the same as the one in https://github.com/electron/windows-installer/tree/main/vendor, so when this value is empty, it defaults to using the squirrel windows from windows-installer.
vendorDirectory
option, which allows using custom squirrel windows