refactor: remove stale handler for extend-info

[t3chguy]

The extend-info read was removed in a23e680 so this if statement never runs

[changeset-bot]

🦋 Changeset detected

Latest commit: f665dd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mmaietta]

Great catch. How did you determine that it was stale?
decode-plist is an undocumented function in https://github.com/develar/app-builder but AFAICT, it shouldn't be returning any entry at that array index either
https://github.com/develar/app-builder/blob/d971224691f6f48555e2a9bb327f99627893372c/pkg/plist/plist.go#L68-L70

[t3chguy]

Great catch. How did you determine that it was stale?

I was looking at ways to work around #8660 by injecting my own data into the asar without it being nuked by the asar integrity calculation and thought extend-info was my golden ticket. Sadly not.

Prior to the linked commit extend-info was a value on buildMetadata ((buildMetadata as any)["extend-info"]) but there is no longer such a key anywhere else in the codebase and indeed the undocumented function returns the same amount as you put in.

[mmaietta]

Are you referring to this extendInfo functionality?

mac: {
  extendInfo: {
    LSUIElement: true,
    CFBundleDocumentTypes: [
      {
        CFBundleTypeName: "Folders",
        CFBundleTypeRole: "Editor",
        LSItemContentTypes: ["public.folder"],
      },
    ],
  },
}

[t3chguy]

Yes, sadly the ASAR integrity thing just overwrites the field rather than merging into it