fix: prevent disabling GPU on the latest Linux kernels#257
Open
Abubakr98 wants to merge 1 commit intoelectron-vite:mainfrom
Open
fix: prevent disabling GPU on the latest Linux kernels#257Abubakr98 wants to merge 1 commit intoelectron-vite:mainfrom
Abubakr98 wants to merge 1 commit intoelectron-vite:mainfrom
Conversation
Add win32 platform check to prevent disabling GPU on Linux kernels that starts with 6.1 (e. g. 6.1, 6.19 etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug where hardware acceleration (GPU, WebGL, WebGPU) is unintentionally disabled for Linux users running kernel versions
6.1and higher (e.g., modern Debian 13, Ubuntu 24.04).What is the problem?
Currently, in
index.ts, there is the following check:if (os.release().startsWith('6.1')) app.disableHardwareAcceleration()This was clearly intended to disable hardware acceleration on Windows 7 (which has the NT kernel version
6.1). However, on Linux,os.release()returns the Linux kernel version. Since modern Linux distributions are now using kernel6.1.xand above, thestartsWith('6.1')condition incorrectly evaluates totrue, forcing the Electron app into a software rendering fallback (SwiftShader) and completely killing GPU performance.How does this PR fix it?
Added a strict
process.platform === 'win32'check before evaluating the OS release version.What is the purpose of this pull request?