-
Notifications
You must be signed in to change notification settings - Fork 258
build: use yarn@v4 and migrate to vitest #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89be1e7 to
818d78c
Compare
dsanders11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mmaietta as he has an earlier draft PR to migrate to Vitest which was blocked by the Node.js 22 bump. Would be good to make sure the two PRs more or less converged on the same end result.
This would be our first repo to venture off of yarn@v1 to yarn@v4. If that's needed to make the Socket security stuff work, sounds like we'd want to migrate most of our repos. Let's put it on the agenda to discuss at the Ecosystem WG meeting this week.
This appears to (a) fix socket dev dependency recognition and (b) make the tests not use deprecated / ancient mocha modules