Skip to content

Commit

Permalink
test: unskip prebuilt-native-module test
Browse files Browse the repository at this point in the history
  • Loading branch information
erickzhao committed Feb 1, 2025
1 parent 64d54e8 commit af687c6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions packages/api/core/spec/slow/api.slow.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,7 @@ describe('Electron Forge API', () => {
await fs.promises.rm(path.resolve(dir, 'out'), { recursive: true, force: true });
});

// FIXME(erickzhao): This test hangs on the electron-rebuild step
// with Electron 19. It was tested to work on Electron 18.
// see https://github.com/electron/forge/pull/2869
describe.skip('with prebuilt native module deps installed', () => {
describe('with prebuilt native module deps installed', () => {
beforeAll(async () => {
await installDeps(dir, ['ref-napi']);
});
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10216,9 +10216,9 @@ no-case@^3.0.4:
tslib "^2.0.3"

node-abi@^3.45.0:
version "3.68.0"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.68.0.tgz#8f37fb02ecf4f43ebe694090dcb52e0c4cc4ba25"
integrity sha512-7vbj10trelExNjFSBm5kTvZXXa7pZyKWx9RCKIyqe6I9Ev3IzGpQoqBP3a+cOdxY+pWj6VkP28n/2wWysBHD/A==
version "3.74.0"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.74.0.tgz#5bfb4424264eaeb91432d2adb9da23c63a301ed0"
integrity sha512-c5XK0MjkGBrQPGYG24GBADZud0NCbznxNx0ZkS+ebUTrmV1qTDxPxSL8zEAPURXSbLRWVexxmP4986BziahL5w==
dependencies:
semver "^7.3.5"

Expand Down

0 comments on commit af687c6

Please sign in to comment.