fix: Allow modification of ChecksumCalculation #3903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This pull request introduces new configuration options for checksum handling in the
PublisherS3
class. The changes primarily focus on allowing users to control checksum calculations and validations for requests and responses to and from S3.This is local only tested against backblaze S3 and cloudflare R2.
Configuration Enhancements:
packages/publisher/s3/src/Config.ts
: AddedrequestChecksumCalculation
andresponseChecksumValidation
options to thePublisherS3Config
interface. These options allow users to specify when checksums should be calculated and validated, respectively.Implementation Updates:
packages/publisher/s3/src/PublisherS3.ts
: Updated thePublisherS3
class to include the new checksum configuration options when creating the S3 client. Default values are set to "WHEN_SUPPORTED" if not provided.