Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec for login item revamp #533

Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat: add spec for login item revamp #533

merged 1 commit into from
Oct 18, 2023

Conversation

codebytere
Copy link
Member

Initial spec for a revamp of app.{set|get}LoginItemSettings(settings).

@bitdisaster
Copy link

This change should support backwards compatibility/migration considering falling scenarios:
When launch on login was enabled with old version:

  1. New version should report the setting via old API.
  2. Disabling in new version should disable via old API
  3. Enabling again should disable in the old API and enable in new API

@codebytere
Copy link
Member Author

codebytere commented Feb 13, 2023

@bitdisaster oh good points - I can update the document to reflect what those cases! Does something like this:

If an app was set as a login item with the previous API, disabling the app as a login item will disable it with the old API. Enabling it again will use the new API. Additionally, it will continue to report login item status via old API until the app has been updated to use the new API.

sufficiently communicate your points in the document?

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this at this stage, but having a migration guide for users of the removed APIs would be good.

Maybe it could be something as simple as a guidance on telling them to implement "open as hidden" as an app-level setting.

@codebytere codebytere requested a review from nornagon April 24, 2023 10:16
@codebytere codebytere requested a review from erickzhao June 14, 2023 13:18
@codebytere codebytere force-pushed the login-items-revamp branch 2 times, most recently from 56fe127 to 9254221 Compare June 14, 2023 19:35
@codebytere
Copy link
Member Author

electron/electron#37244 has now been merged.

@codebytere codebytere merged commit fd4c88d into main Oct 18, 2023
2 checks passed
@codebytere codebytere deleted the login-items-revamp branch October 18, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants