-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add spec for login item revamp #533
Conversation
dfaa3f8
to
892006f
Compare
This change should support backwards compatibility/migration considering falling scenarios:
|
@bitdisaster oh good points - I can update the document to reflect what those cases! Does something like this:
sufficiently communicate your points in the document? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this at this stage, but having a migration guide for users of the removed APIs would be good.
Maybe it could be something as simple as a guidance on telling them to implement "open as hidden" as an app-level setting.
56fe127
to
9254221
Compare
9254221
to
304a376
Compare
electron/electron#37244 has now been merged. |
Initial spec for a revamp of
app.{set|get}LoginItemSettings(settings)
.